Honesty/home
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(js): 优化主题切换按钮的jQuery选择器使用

Browse Source 
- 将重复的$('#theme-btn')选择器调用提取为常量themeBtn
- 提高代码可读性和维护性
- 避免重复查询DOM元素提升性能
This commit is contained in:
hehh
2025-11-25 10:59:59 +08:00
parent efcf398ee7
commit 05cc13a0a8
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
js/about.js
View File

@@ -184,21 +184,22 @@ class ThemeManager {
init() { init() {
let theme = getStoredTheme(); let theme = getStoredTheme();
if (theme) this.root.setAttribute('data-theme', theme); if (theme) this.root.setAttribute('data-theme', theme);
$('#theme-btn').toggleClass('is-active', theme === 'night'); const themeBtn = $('#theme-btn');
themeBtn.toggleClass('is-active', theme === 'night');
const langForTitle = getStoredLanguage(); const langForTitle = getStoredLanguage();
const titleText = theme === 'night' ? (langForTitle === 'zh' ? '白天模式' : 'Day') : (langForTitle === 'zh' ? '黑夜模式' : 'Night'); const titleText = theme === 'night' ? (langForTitle === 'zh' ? '白天模式' : 'Day') : (langForTitle === 'zh' ? '黑夜模式' : 'Night');
$('#theme-btn').attr('title', titleText); themeBtn.attr('title', titleText);
$('#theme-btn').on('click', () => { themeBtn.on('click', () => {
const curr = this.root.getAttribute('data-theme'); const curr = this.root.getAttribute('data-theme');
const next = curr === 'night' ? 'day' : 'night'; const next = curr === 'night' ? 'day' : 'night';
if (next) this.root.setAttribute('data-theme', next); if (next) this.root.setAttribute('data-theme', next);
else this.root.removeAttribute('data-theme'); else this.root.removeAttribute('data-theme');
setStoredTheme(next) setStoredTheme(next)
$('#theme-btn').toggleClass('is-active', next === 'night'); themeBtn.toggleClass('is-active', next === 'night');
const lang = getStoredLanguage(); const lang = getStoredLanguage();
const t = next === 'night' ? (lang === 'zh' ? '白天模式' : 'Day') : (lang === 'zh' ? '黑夜模式' : 'Night'); const t = next === 'night' ? (lang === 'zh' ? '白天模式' : 'Day') : (lang === 'zh' ? '黑夜模式' : 'Night');
$('#theme-btn').attr('title', t); themeBtn.attr('title', t);
// 更新Artalk主题 // 更新Artalk主题
if (typeof Artalk !== 'undefined') { if (typeof Artalk !== 'undefined') {